chore: Partial revert - remove TimeSpan Timeout option #146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #136, I added the
TimeSpan Timeoutoption, with the goal of eventually replacingDouble? RequestTimeout. The goal is to accept aTimeSpanand not a number which we then convert to a TimeSpan internally - this is a best practice in .NET and really everywhere I'd say.After reviewing this in more detail, I decided I don't like the name
Timeoutbecause it's vague. I'd really like to keep the nameRequestTimeout, but we can't change it toTimeSpan RequestTimeoutwithout making a breaking change.Instead of deprecating
RequestTimeout, I'd prefer to change its type toTimeSpanin 8.x directly. I realise we're not giving advance notice of this breaking change, but at least it's a trivial change:I only noticed this issue when updating the docs for 7.1.0, which is not yet released.